Fix Adorner Layer Clipping #13921
Merged
Fix Adorner Layer Clipping #13921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user should be able to set this on an adorner themselves.
Only take the adorned visual's clip bounds into account if the adorner is clipped to these bounds.
grokys
added
bug
backport-candidate-11.0.x
Default setting is `true`, but this was being overridden in `AdornerLayer.AddVisualAdorner`. That was fixed by an earlier commit in this PR, so property needs to be set explicitly to false in ControlCatalog.
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Jan 17, 2024
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
maxkatz6
pushed a commit
that referenced
this pull request
Jan 17, 2024
* Don't overwrite IsClipEnabled. The user should be able to set this on an adorner themselves. * Use correct clip bounds for adorners. Only take the adorned visual's clip bounds into account if the adorner is clipped to these bounds. * Disable clipping on GridSplitter adorner. Fixes #10700 * Don't clip adorners in ControlCatalog. Default setting is `true`, but this was being overridden in `AdornerLayer.AddVisualAdorner`. That was fixed by an earlier commit in this PR, so property needs to be set explicitly to false in ControlCatalog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Fixes two problems described in #10701:
AdornerLayer.IsClipEnabledwhen adding an adorner to the adorner layer: this property should be set by the user.ScrollViewerartifacts described in Broken Adorner Layer Invalidation or Clipping #10701 (comment)Also fixes #10700 by setting
AdornerLayer.IsClipEnabledto false onGridSplitter's adorner.Fixed issues
FIxes #10700
Fixes #10701